Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define JavaScript runtimes semantic conventions #2290

Merged
merged 10 commits into from
Mar 2, 2022

Conversation

legendecas
Copy link
Member

@legendecas legendecas commented Jan 25, 2022

Fixes open-telemetry/opentelemetry-js#1544

Changes

Defines JavaScript runtime semantic convention values.

Related: open-telemetry/opentelemetry-js#2727

/cc @open-telemetry/javascript-approvers

@arminru arminru added area:semantic-conventions Related to semantic conventions spec:resource Related to the specification/resource directory labels Jan 25, 2022
@arminru arminru requested a review from a team January 25, 2022 10:44
@legendecas
Copy link
Member Author

Since process.runtime.description adds no information for Node.js and browser runtimes, I'd omit it for now and remove it from this PR.

@github-actions
Copy link

github-actions bot commented Feb 3, 2022

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Feb 3, 2022
@legendecas
Copy link
Member Author

@tigrannajaryan would you mind taking another look? thank you!

@github-actions github-actions bot removed the Stale label Feb 7, 2022
@legendecas
Copy link
Member Author

markdownlint failed for unrelated changes:

./experimental/trace/zpages.md:59:480 MD037/no-space-in-emphasis Spaces inside emphasis markers [Context: "* number of buckets = 5 *"]

@arminru
Copy link
Member

arminru commented Feb 7, 2022

markdownlint failed for unrelated changes:

./experimental/trace/zpages.md:59:480 MD037/no-space-in-emphasis Spaces inside emphasis markers [Context: "* number of buckets = 5 *"]

@legendecas A breaking change was introduced in markdownlint-cli, #2320 should fix this.

@legendecas
Copy link
Member Author

@arminru thanks for the fix! branch updated.

@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Feb 16, 2022
@github-actions
Copy link

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Feb 24, 2022
@legendecas
Copy link
Member Author

This should not be closed as inactive, I'd believe it is ready to land. @open-telemetry/specs-approvers please take a look at this, thank you!

@legendecas
Copy link
Member Author

legendecas commented Feb 25, 2022

It seems like I don't have permission to reopen the PR. :(

@dyladan
Copy link
Member

dyladan commented Feb 25, 2022

@open-telemetry/technical-committee @open-telemetry/specs-approvers @open-telemetry/specs-triagers please reopen :)

@arminru arminru reopened this Feb 25, 2022
@arminru arminru removed the Stale label Feb 25, 2022
@legendecas
Copy link
Member Author

@open-telemetry/specs-approvers, this has waited for tens of days, would you mind merging this PR? Another PR open-telemetry/opentelemetry-js#2727 is still waiting for this to land. Many thanks!

@arminru arminru merged commit 9faecf4 into open-telemetry:main Mar 2, 2022
@legendecas legendecas deleted the semantic-js-runtime branch March 21, 2022 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:semantic-conventions Related to semantic conventions spec:resource Related to the specification/resource directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confirm specification for runtime information
6 participants