Add details to Prometheus Exporter requirement #2124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyang
added
area:sdk
jmacd
approved these changes
Nov 15, 2021
MrAlias
reviewed
Nov 16, 2021
jack-berg
reviewed
Nov 16, 2021
bogdandrutu
reviewed
Nov 16, 2021
|
The Prom pushgateway comes with a lot of caveats, for example: I would prefer to see us put our resources behind finishing push support for OTLP. Prometheus provides a way to join service-discovered attributes with application-provided attributes, and we would like a way to do this with OTLP. When we can do that with OTLP, then clients can send OTLP to a collector, have their service discovery labels applied, and then exported via Prometheus Remote Write. We have not discussed adding Prom pushgateway support in the collector, and I don't think we should. |
|
(Issue about service discovery for pushed metrics: #1078) |
reyang
force-pushed
the
reyang/metrics-prometheus-exporter
branch
from
761a3fc
to
a19943d
Compare
MrAlias
reviewed
Nov 17, 2021
MrAlias
reviewed
Nov 18, 2021
cijothomas
approved these changes
Nov 20, 2021
reyang
added
the
release:allowed-for-ga
jsuereth
approved these changes
Nov 30, 2021
jack-berg
approved these changes
Nov 30, 2021
Committing these as Reiley has requested for help from native english speakers. Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
jmacd
approved these changes
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Please provide a brief description of the changes here. Update the
CHANGELOG.mdfor non-trivial changes. IfCHANGELOG.mdis updated,also be sure to update
spec-compliance-matrix.mdif necessary.Related issues #2017, #2035