Explain expected usage of log body #2096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurishkuro
approved these changes
Nov 2, 2021
pmm-sumo
approved these changes
Nov 2, 2021
tigrannajaryan
approved these changes
Nov 3, 2021
zenmoto
approved these changes
Nov 3, 2021
kumoroku
approved these changes
Nov 4, 2021
|
I think we have enough approvals and this was unchanged for 2 days. Merging. |
|
@djaglowski I copy/pasted the PR description into commit message. Please populate the commit message in future PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2066 and #1752
Supports #2068
Changes
Adds a note to the log data model which explains the intended usage of the
Bodyfield.Additional Context
Extensive discussion has been had on this issue on #1613, as well as in the Log SIG group.