Fix attributes names in Google Cloud Logging mapping #2093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tigrannajaryan
force-pushed
the
fix-attrnames-googlecloudlogs
branch
2 times, most recently
from
a3fafb4
to
2056253
Compare
kumoroku
approved these changes
Nov 4, 2021
|
@jsuereth PTAL |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
@jsuereth please have a look. |
arminru
approved these changes
Nov 18, 2021
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
@jsuereth PTAL. |
Vendor-specific attribute names must be prefixed with reverse FQDN, see recommendation here https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/common/attribute-naming.md#recommendations-for-application-developers
tigrannajaryan
force-pushed
the
fix-attrnames-googlecloudlogs
branch
from
ce41855
to
123fee8
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
@jsuereth PTAL. |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
@jsuereth PTAL. |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
I think this is safe to merge as it is merely in the Examples section. If later anyone from Google wants to fix it that's fine too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vendor-specific attribute names must be prefixed
with reverse FQDN, see recommendation here
https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/common/attribute-naming.md#recommendations-for-application-developers