Change mapping for log_name of Google Cloud Logging #2092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tigrannajaryan
force-pushed
the
fix-googlecloudlogs-mapping
branch
from
cc47b94
to
2d8ba6e
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
@jsuereth PTAL |
jmacd
approved these changes
Nov 15, 2021
|
@jsuereth Would you please give this a review? The Log SIG has interest in seeing the underlying issue closed before the data model is declared stable. |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
@jsuereth PTAL. |
jsuereth
approved these changes
Dec 10, 2021
tigrannajaryan
force-pushed
the
fix-googlecloudlogs-mapping
branch
from
2d8ba6e
to
a2355b3
Compare
Fixes open-telemetry#1808 The log_name should not map to Name, they are not the same thing. log_name description: The resource name of the log to which this log entry belongs. (See https://cloud.google.com/logging/docs/reference/v2/rpc/google.logging.v2#logentry) Name description: Short event identifier that does not contain varying parts. log_name is now mapped to a Google-specific attribute. If better mapping is known I can change to that but I don't see anything else in log data model log_name maps nicely to.
tigrannajaryan
force-pushed
the
fix-googlecloudlogs-mapping
branch
from
a2355b3
to
9cebe99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1808
The log_name should not map to Name, they are not the same thing.
log_name description: The resource name of the log to which this log entry belongs.
(See https://cloud.google.com/logging/docs/reference/v2/rpc/google.logging.v2#logentry)
Name description: Short event identifier that does not contain varying parts.
log_name is now mapped to a Google-specific attribute. If better mapping is known
I can change to that but I don't see anything else in log data model log_name maps
nicely to.