Clarify OTLP/HTTP port handling. #1985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oberon00
added
area:sdk
Oberon00
commented
Oct 4, 2021
anuraaga
approved these changes
Oct 4, 2021
iNikem
approved these changes
Oct 4, 2021
jsuereth
reviewed
Oct 4, 2021
carlosalberto
approved these changes
Oct 5, 2021
arminru
approved these changes
Oct 7, 2021
reyang
approved these changes
Oct 12, 2021
jsuereth
approved these changes
Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarifies that default ports for the URL schemes, not default OTLP/HTTP port should be used if no port is given in URL.
See #1975 (comment)