Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify difference between container.name and k8s.container.name #1980

Merged
merged 2 commits into from
Nov 4, 2021
Merged

Clarify difference between container.name and k8s.container.name #1980

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b312a2
Clarify difference between `container.name` and `k8s.container.name`
dmitryax Oct 1, 2021
ac82c39
Merge branch 'main' into clarify-container-name-difference
bogdandrutu Nov 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion semantic_conventions/resource/container.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ groups:
- id: name
type: string
brief: >
Container name.
Container name used by container runtime.
examples: ['opentelemetry-autoconf']
dmitryax marked this conversation as resolved.
Show resolved Hide resolved
- id: id
type: string
Expand Down
4 changes: 3 additions & 1 deletion semantic_conventions/resource/k8s.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,9 @@ groups:
- id: name
type: string
brief: >
The name of the Container in a Pod template.
The name of the Container from Pod specification, must be unique
within a Pod. Container runtime usually uses different globally unique
name (`container.name`).
examples: ['redis']
- id: restart_count
type: int
Expand Down
2 changes: 1 addition & 1 deletion specification/resource/semantic_conventions/container.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<!-- semconv container -->
| Attribute | Type | Description | Examples | Required |
|---|---|---|---|---|
| `container.name` | string | Container name. | `opentelemetry-autoconf` | No |
| `container.name` | string | Container name used by container runtime. | `opentelemetry-autoconf` | No |
| `container.id` | string | Container ID. Usually a UUID, as for example used to [identify Docker containers](https://docs.docker.com/engine/reference/run/#container-identification). The UUID might be abbreviated. | `a3bf90e006b2` | No |
| `container.runtime` | string | The container runtime managing this container. | `docker`; `containerd`; `rkt` | No |
| `container.image.name` | string | Name of the image the container was built on. | `gcr.io/opentelemetry/operator` | No |
Expand Down
2 changes: 1 addition & 1 deletion specification/resource/semantic_conventions/k8s.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ to a running container.
<!-- semconv k8s.container -->
| Attribute | Type | Description | Examples | Required |
|---|---|---|---|---|
| `k8s.container.name` | string | The name of the Container in a Pod template. | `redis` | No |
| `k8s.container.name` | string | The name of the Container from Pod specification, must be unique within a Pod. Container runtime usually uses different globally unique name (`container.name`). | `redis` | No |
| `k8s.container.restart_count` | int | Number of times the container was restarted. This attribute can be used to identify a particular container (running or stopped) within a container spec. | `0`; `2` | No |
<!-- endsemconv -->

Expand Down