Specify result of Resource.merge error #1726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tigrannajaryan
approved these changes
May 27, 2021
arminru
approved these changes
May 28, 2021
arminru
added
area:sdk
MrAlias
approved these changes
Jun 1, 2021
|
cc @bogdandrutu |
6 tasks
bogdandrutu
approved these changes
Jun 7, 2021
carlosalberto
approved these changes
Jun 7, 2021
|
@dgetu Could you rebase this PR (or allow mantainers to update your branch)? |
The specification currently states that merging Resources and aggregating ResourceDetectors results in an error, but does not say anything about the resource with which the program continues to operate. This change specifies that the resultant resource of these methods is undefined and the decision is left to each implementation.
dgetu
force-pushed
the
specify-result-of-resource-merge-error
branch
from
072b426
to
045cfdf
Compare
|
Rebase done! |
|
I believe this is safe to include in 1.4.0. @carlosalberto unless anyone objects let's merge before 1.4.0 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The specification currently states that merging Resources and aggregating
ResourceDetectors results in an error, but does not say anything about the
resource with which the program continues to operate. This change specifies
that the resultant resource of these methods is undefined and the decision is
left to each implementation.