Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor non-OTLP Format Mapping and Fix Dropped Attribute Count bug #1662

Commits on Apr 30, 2021

  1. Refactor non-OTLP Format Mapping and Fix Dropped Attribute Count bug

    Fixes open-telemetry#1656
    
    The documents that describe transformations to Jaeger and Zipkin contained
    duplicate information about how to record InstrumentationLibrary.
    
    They also contained incomplete and incorrect information about how to record
    dropped attribute count.
    
    This change extracts common transformation rules into a separate document (non-otlp.md)
    and references this document where appropriate.
    
    We also define otel.event.dropped_attributes_count as the only way to record
    dropped attribute count, regardless of the entity for which it is recorded.
    Previously in Jaeger format we specified that for Events we must use
    otel.event.dropped_attributes_count and did not specify at all what to use for Spans.
    
    I believe using the same uniform key for Spans and Events is correct.
    
    I consider this a specification bug and do not believe it should be treated as
    a breaking change.
    
    Also delete the Zipkin mapping for LocalChildSpanCount since there is no such
    OpenTelemetry field anymore.
    tigrannajaryan committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    5b71287 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2021

  1. Configuration menu
    Copy the full SHA
    f8e551a View commit details
    Browse the repository at this point in the history