added JSON RPC specific attributes #1643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arminru
reviewed
Apr 26, 2021
arminru
reviewed
Apr 26, 2021
semantic_conventions/trace/rpc.yaml
Outdated
Comment on lines
97
to
100
| - id: id | ||
| type: string | ||
| brief: "`id` property of request. Since protocol allows id to be int, string, `null` or missing (for notifications), value is expected to be cast to string for simplicity. Omit if this is a notification." | ||
| examples: ['10', 'request-7', ''] |
There was a problem hiding this comment.
I wonder if this would be generic enough to be added on the parent-level (e.g., as rpc.call_id or rpc.request_id) so we don't have overlaps/duplicates later if this is added for other protocols/frameworks as well. @open-telemetry/specs-approvers @open-telemetry/specs-trace-approvers any opinions?
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
|
Fixed and replied where i could |
arminru
reviewed
Apr 27, 2021
There was a problem hiding this comment.
Thanks!
Please ignore the failing docfx check for now, it's just Chocolatey currently being down (https://status.chocolatey.org).
arminru
reviewed
Apr 27, 2021
arminru
added
area:semantic-conventions
…elemetry-specification into jsonrpc-trace-conventions
arminru
reviewed
Apr 29, 2021
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
arminru
approved these changes
May 4, 2021
carlosalberto
approved these changes
May 4, 2021
arminru
added a commit
that referenced
this pull request
May 10, 2021
This entry slipped into the wrong section. The PR was merged after 1.3.0 was released.
bogdandrutu
pushed a commit
that referenced
this pull request
May 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is second attempt: PR #1606 was automatically closed by bot.
Tracing attributes for JSON RPC protocol.
Changes
Added attributes:
Not sure if
nullvalues are OK for attributes, maybe need to changerpc.jsonrpc.ida bit. Also not sure iferror_messageis OK because it is arbitrary (but short!) text, can impact cardinality.Related issue: #1601