Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify the TraceIdRatioBased description format #1536

Merged
merged 6 commits into from
Mar 15, 2021
Merged

Clarify the TraceIdRatioBased description format #1536

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
55ca482
Clarify the TraceIdRatioBased description format
MrAlias Mar 11, 2021
6901c2b
Update specification/trace/sdk.md
MrAlias Mar 12, 2021
084159e
Merge branch 'main' into tirb-sampler-desc
MrAlias Mar 12, 2021
d803627
Add changes to CHANGELOG
MrAlias Mar 12, 2021
2b8e2a5
Merge branch 'main' into tirb-sampler-desc
carlosalberto Mar 15, 2021
34e1f47
Update specification/trace/sdk.md
carlosalberto Mar 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion specification/trace/sdk.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,13 @@ The default sampler is `ParentBased(root=AlwaysOn)`.
* The `TraceIdRatioBased` MUST ignore the parent `SampledFlag`. To respect the
parent `SampledFlag`, the `TraceIdRatioBased` should be used as a delegate of
the `ParentBased` sampler specified below.
* Description MUST be `TraceIdRatioBased{0.000100}`.
* Description MUST return a string of the form `"TraceIdRatioBased{RATIO}"`
with `RATIO` replaced with the Sampler instances' trace sampling ratio
MrAlias marked this conversation as resolved.
Show resolved Hide resolved
represented as a decimal number. The precision of the number SHOULD follow
implementation language standards and SHOULD be high enough to identify when
Samplers have different ratios. For example, if a TraceIdRatioBased Sampler
had a sampling ratio of 1 to every 10,000 spans it could return
carlosalberto marked this conversation as resolved.
Show resolved Hide resolved
`"TraceIdRatioBased{0.000100}"` as its description.

TODO: Add details about how the `TraceIdRatioBased` is implemented as a function
of the `TraceID`. [#1413](https://github.com/open-telemetry/opentelemetry-specification/issues/1413)
Expand Down