[For 1.0] Add WARNING for TraceIdRatioBased algorithm stability. #1414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
jkwatson
reviewed
Feb 9, 2021
specification/trace/sdk.md
Outdated
| sampling rate than the frontend system, this way all frontend traces will | ||
| still be sampled and extra traces will be sampled on the backend only. | ||
| * **WARNING:** Since the exact algorithm is not specified yet (see TODO above), | ||
| there will probably be be breaking changes to it in any language SDK once it is. |
There was a problem hiding this comment.
This language makes it sound like we will be required to bump to a 2.0.0 version when this is specified. Is that the intent?
There was a problem hiding this comment.
The intent was exactly to avoid that. Maybe there is a better word than "breaking" here? Or "if you rely on the algorithm, your code will break"?
bogdandrutu
reviewed
Feb 9, 2021
Oberon00
changed the title
Oberon00
changed the title
Merged
punya
approved these changes
Feb 9, 2021
jsuereth
approved these changes
Feb 9, 2021
carlosalberto
approved these changes
Feb 9, 2021
yurishkuro
reviewed
Feb 9, 2021
cijothomas
approved these changes
Feb 9, 2021
bogdandrutu
approved these changes
Feb 9, 2021
|
@yurishkuro are you ok to move with this option then? |
yurishkuro
approved these changes
Feb 9, 2021
|
sgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for releasing 1.0 (#1373).
Alternative to PR #1412.
See #1372 (comment)
TraceIdRatioBased is only vaguely specified and has a TODO in it. We should call attention to the resulting unstable-ness of the algorithm.