Skip to content

Commit

Permalink
Clarify what does wildcard mean in the Metrics SDK View (#2325)
Browse files Browse the repository at this point in the history
* Clarify what does wildcard mean in the Metrics SDK View

* changelog

* Update specification/metrics/sdk.md

Co-authored-by: Diego Hurtado <ocelotl@users.noreply.github.com>

* feedback

* fix url

Co-authored-by: Diego Hurtado <ocelotl@users.noreply.github.com>
Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com>
  • Loading branch information
3 people committed Feb 11, 2022
1 parent 6f52c98 commit a1aa19c
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ release.
[#2032](https://github.com/open-telemetry/opentelemetry-specification/pull/2061)
- Changed default Prometheus Exporter host from `0.0.0.0` to `localhost`.
([#2282](https://github.com/open-telemetry/opentelemetry-specification/pull/2282))
- Clarified wildcard and predicate support in metrics SDK View API.
([#2325](https://github.com/open-telemetry/opentelemetry-specification/pull/2325))

### Logs

Expand Down
5 changes: 4 additions & 1 deletion specification/metrics/sdk.md
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,10 @@ are the inputs:

* The Instrument selection criteria (required), which covers:
* The `type` of the Instrument(s) (optional).
* The `name` of the Instrument(s), with wildcard support (optional).
* The `name` of the Instrument(s). [OpenTelemetry SDK](../overview.md#sdk)
authors MAY choose to support wildcard characters, with the question mark
(`?`) matching exactly one character and the asterisk character (`*`)
matching zero or more characters.
* The `name` of the Meter (optional).
* The `version` of the Meter (optional).
* The `schema_url` of the Meter (optional).
Expand Down

0 comments on commit a1aa19c

Please sign in to comment.