Skip to content

Commit

Permalink
Use *Data proto messages for file exporter (#3809)
Browse files Browse the repository at this point in the history
Fixes #2390

## Changes

The `*Request` proto messages are design for RPC/REST communication
(request, response style) and may contain in the future information
specific to this type of communication.

The `*Data` proto messages are design for cases where only the telemetry
data must be encoded without ony OTLP specific metadata.

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
  • Loading branch information
bogdandrutu committed Jan 11, 2024
1 parent c6520a7 commit 3a13acc
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,8 @@ release.

### OpenTelemetry Protocol

- Use `TracesData`, `MetricsData` and `LogsData` proto messages for file exporter.

### Compatibility

### SDK Configuration
Expand Down
2 changes: 1 addition & 1 deletion specification/protocol/file-exporter.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ This defines the first version of the serialization scheme.
The data must be encoded according to the format specified in the
[OTLP JSON Encoding](https://github.com/open-telemetry/opentelemetry-proto/blob/main/docs/specification.md#json-protobuf-encoding).

Only top-level objects, `ExportTraceServiceRequest`, `ExportMetricsServiceRequest`, and `ExportLogsServiceRequest` are supported.
Only top-level objects, `TracesData`, `MetricsData`, and `LogsData` are supported.

Files must contain exactly one type of data: traces, metrics, or logs.

Expand Down

0 comments on commit 3a13acc

Please sign in to comment.