Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove opentelemetry-jaeger #1782

Merged
merged 2 commits into from
May 18, 2024

Conversation

cijothomas
Copy link
Member

@cijothomas cijothomas commented May 18, 2024

Fixes #995

@cijothomas cijothomas requested a review from a team as a code owner May 18, 2024 04:08
Copy link

codecov bot commented May 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.1%. Comparing base (2863632) to head (d959e49).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1782     +/-   ##
=======================================
+ Coverage   71.6%   74.1%   +2.4%     
=======================================
  Files        136     125     -11     
  Lines      20857   19484   -1373     
=======================================
- Hits       14948   14449    -499     
+ Misses      5909    5035    -874     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@hdost hdost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bye boo 👋🏼

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. It's more important to have a fix for #761 now, as people migrating from opentelemetry-jaeger to opentelemetry-otlp may be stuck with this issue. Will be spending some time this week to have a fix.

@TommyCpp TommyCpp merged commit 2210d7b into open-telemetry:main May 18, 2024
21 checks passed
@cijothomas cijothomas deleted the cijothomas/jaeger-remove branch May 18, 2024 21:16
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecating opentelemetry-jaeger
4 participants