Build wheels from source dists #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some operating systems (such as SUSE with py2pack) have an easier time packaging source distributions. Adding a check for the setup.py before attempting to build distributions.
toumorokoshi
approved these changes
Feb 20, 2020
There was a problem hiding this comment.
LGTM. I'm good with not merging in #433 and using this instead.
|
I think that would have been doable with some |
srikanthccv
pushed a commit
to srikanthccv/opentelemetry-python
that referenced
this pull request
Nov 1, 2020
* feat(metrics): add registerMetric and getMetric functionality * fix: getTimeSeries and add more tests * fix: minor * fix: add JSDoc * fix: minor * fix: remove * fix: replace String -> string * fix: avoid casting * fix: use GAUGE_DOUBLE and COUNTER_DOUBLE type * fix: add ValueType to indicate type of the metric * fix: move ValueType.DOUBLE to DEFAULT_METRIC_OPTIONS * fix: use Number.isInteger * fix: log an error instead of throw error * fix: add more test and @todo comment * fix: link open-telemetry#474 isssue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #252
Follow up to #433. This replaces
setup.py bdist_wheelwithpip wheel, but should produce the same artifacts. @Oberon00, @toumorokoshi, please sanity check me on this.