Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: consider only pull request event when running public-symbols-check #4195

Merged
merged 3 commits into from
Sep 19, 2024

Conversation

xrmx
Copy link
Contributor

@xrmx xrmx commented Sep 18, 2024

Description

Not sure it's the right fix but intuitively we need to look for pull request event label only if the event is a pull request. As previously done for the changelog in 43d818e . While at it fix the label name in docs and scripts.

Refs #4185

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A

Does This PR Require a Contrib Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@xrmx xrmx added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Sep 19, 2024
@xrmx xrmx requested a review from a team as a code owner September 19, 2024 08:00
@xrmx xrmx enabled auto-merge (squash) September 19, 2024 08:01
@xrmx xrmx merged commit 6baea36 into open-telemetry:main Sep 19, 2024
377 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants