Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate workflow files with a Jinja template #4041

Merged
merged 6 commits into from
Aug 15, 2024
Merged

Generate workflow files with a Jinja template #4041

merged 6 commits into from
Aug 15, 2024

Conversation

ocelotl
Copy link
Contributor

@ocelotl ocelotl commented Jul 10, 2024

Fixes #4040

@ocelotl ocelotl self-assigned this Jul 10, 2024
@ocelotl ocelotl requested a review from a team July 10, 2024 19:34
@ocelotl ocelotl added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jul 10, 2024
@ocelotl ocelotl changed the title Remove duplication of test running information Generate workflow files with a Jinja template Jul 15, 2024
xrmx
xrmx reviewed Jul 16, 2024
View reviewed changes
tox.ini Outdated Show resolved Hide resolved
@ocelotl ocelotl force-pushed the issue_4040 branch 2 times, most recently from 429c4ba to 3f1ca38 Compare July 17, 2024 01:22
@ocelotl ocelotl force-pushed the issue_4040 branch 4 times, most recently from 24866ef to 0430eb2 Compare July 31, 2024 16:42
ocelotl
ocelotl commented Jul 31, 2024
View reviewed changes
tox.ini Outdated Show resolved Hide resolved
emdneto
emdneto reviewed Aug 6, 2024
View reviewed changes
Copy link
Member

@emdneto emdneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems we need to sync the fastapi test to match the new tests that we have in contrib repo which are: fastapi-main and fastapi-slim

@ocelotl ocelotl mentioned this pull request Aug 15, 2024
Merged
@ocelotl ocelotl merged commit b2b133d into open-telemetry:main Aug 15, 2024
376 checks passed
@ocelotl ocelotl deleted the issue_4040 branch August 15, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrmx xrmx xrmx left review comments

@emdneto emdneto emdneto left review comments

@lzchen lzchen lzchen approved these changes

Assignees

@ocelotl ocelotl

Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Duplicate test running information in tox.ini and CI workflows
4 participants
@ocelotl @xrmx @emdneto @lzchen