Rename test objects to avoid pytest warnings #3823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
geetikabatra
force-pushed
the
warn
branch
2 times, most recently
from
9b7b8cc
to
417878d
Compare
|
I did sign the CLA, the check still fails, don't know why. |
|
Commits authored by you are not associated with the email. Can you make sure you set the git config email details and open a separate PR? |
xrmx
reviewed
Mar 29, 2024
|
@srikanthccv Will create a new PR, @xrmx Any other name that you would like to suggest? |
Other tests use the Dummy prefix |
|
@geetikabatra Hey, sorted out the CLA? |
|
Hey, gimme a couple of days. I am a new mother, so not able to be consistent. Would soon wind this up. |
|
Nice fix! 😎 |
ocelotl
approved these changes
Apr 17, 2024
ocelotl
added
the
Approve Public API check
geetikabatra
force-pushed
the
warn
branch
2 times, most recently
from
c8f60e9
to
757a4ef
Compare
This PR removes unneccesary warnings
Fixes: open-telemetry#3779
|
CLA is fixed now. @srikanthccv and @xrmx. |
srikanthccv
approved these changes
May 4, 2024
xrmx
reviewed
May 6, 2024
xrmx
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes unneccesary warnings
Fixes: #3779
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
Answer the following question based on these examples of changes that would require a Contrib Repo Change:
The OTel specification has changed which prompted this PR to update the method interfaces of
opentelemetry-api/oropentelemetry-sdk/The method interfaces of
test/utilhave changedScripts in
scripts/that were copied over to the Contrib repo have changedConfiguration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in
pyproject.tomlisort.cfg.flake8When a new
.github/CODEOWNERis addedMajor changes to project information, such as in:
README.mdCONTRIBUTING.mdYes. - Link to PR:
No.
Checklist: