Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: timeout period when acquiring grpc exporter lock on shutdown #3524

Merged
merged 3 commits into from
Nov 16, 2023

Conversation

seemk
Copy link
Contributor

@seemk seemk commented Nov 10, 2023

Description

Lock.acquire with timeout takes a seconds parameter not milliseconds. Currently if the exporting is not successful the acquire takes much longer than the intended timeout.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@seemk seemk requested a review from a team November 10, 2023 16:29
Copy link
Member

@pmcollins pmcollins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thanks for the fix, Siim.

Copy link
Member

@aabmass aabmass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@ocelotl ocelotl enabled auto-merge (squash) November 16, 2023 19:46
@ocelotl ocelotl merged commit 36aaa84 into open-telemetry:main Nov 16, 2023
111 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants