Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add param for indent size to LogRecord.to_json() #2870

Merged
merged 5 commits into from
Aug 20, 2022
Merged

Add param for indent size to LogRecord.to_json() #2870

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f7aa32e
Add param for indent size to LogRecord.to_json()
dougramirez Aug 10, 2022
3561bb3
Updated Changelog
dougramirez Aug 10, 2022
b2928c9
Merge branch 'main' into log-to-json-indent
dougramirez Aug 17, 2022
a598403
Merge branch 'main' into log-to-json-indent
srikanthccv Aug 17, 2022
a51bedd
Merge branch 'main' into log-to-json-indent
srikanthccv Aug 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

- Add param for `indent` size to `LogRecord.to_json()`
([#2870](https://github.com/open-telemetry/opentelemetry-python/pull/2870))
- Add `force_flush` method to metrics exporter
([#2852](https://github.com/open-telemetry/opentelemetry-python/pull/2852))
- Change tracing to use `Resource.to_json()`
Expand Down
4 changes: 2 additions & 2 deletions opentelemetry-sdk/src/opentelemetry/sdk/_logs/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ def __eq__(self, other: object) -> bool:
return NotImplemented
return self.__dict__ == other.__dict__

def to_json(self) -> str:
def to_json(self, indent=4) -> str:
return json.dumps(
{
"body": self.body,
Expand All @@ -97,7 +97,7 @@ def to_json(self) -> str:
if self.resource
else "",
},
indent=4,
indent=indent,
)


Expand Down