-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tracing decorator with late configuration #2754
Merged
lzchen
merged 11 commits into
open-telemetry:main
from
oceyral:fix_tracing_decorator_with_late_config
Jul 6, 2022
Merged
Fix tracing decorator with late configuration #2754
lzchen
merged 11 commits into
open-telemetry:main
from
oceyral:fix_tracing_decorator_with_late_config
Jul 6, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@oceyral please sign the CLA |
@ocelotl yes, I'm trying to navigate corporate structure to get validated as a contributor, sorry if it takes a bit of time |
@ocelotl got the CLA signed ! I also tried fixing mypy/lint tests, but I'm not sure about the other failing tests, I had a look but it doesn't look related to my PR. |
ocelotl
approved these changes
Jul 6, 2022
lzchen
approved these changes
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to #2621 and #2708
When using the tracing decorator documented as part of the issue and PR above, functions might not actually be instrumented when the decorator is used on a function before a tracing provider is configured.
Considering the following case :
Here, the
toto
function will not actually be instrumented, even after configuration of a tracing provider. This is particularly problematic with instrumenting submodules for example, because if the module is imported before a tracer provider is configured, most uses of the decorator will be no-ops, and no tracing will be done.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
Checklist: