Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support logs SDK auto instrumentation enable/disable with env #2728

Merged
merged 5 commits into from
Jun 7, 2022

Conversation

srikanthccv
Copy link
Member

Description

Fixes #2594

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • tox -e opentelemetry-sdk

Does This PR Require a Contrib Repo Change?

  • No.

@srikanthccv srikanthccv marked this pull request as ready for review June 1, 2022 21:09
@srikanthccv srikanthccv requested a review from a team June 1, 2022 21:09
Copy link
Contributor

@ocelotl ocelotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srikanthccv please just fix that minor typo before merging ✌️

Co-authored-by: Diego Hurtado <ocelotl@users.noreply.github.com>
@srikanthccv srikanthccv merged commit 928d333 into open-telemetry:main Jun 7, 2022
@srikanthccv srikanthccv deleted the issue-2594 branch June 7, 2022 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

opentelemetry-instrument and logs SDK cause logs to be swallowed by default
3 participants