Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Measurement to Observation #2617

Merged
merged 5 commits into from
Apr 20, 2022
Merged

Rename Measurement to Observation #2617

merged 5 commits into from
Apr 20, 2022

Conversation

ocelotl
Copy link
Contributor

@ocelotl ocelotl commented Apr 18, 2022

Fixes #2451

@ocelotl ocelotl self-assigned this Apr 18, 2022
@ocelotl ocelotl requested a review from a team April 18, 2022 21:11
lzchen
lzchen reviewed Apr 18, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
lzchen
lzchen reviewed Apr 18, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
lzchen
lzchen approved these changes Apr 18, 2022
View reviewed changes
Copy link
Contributor

@lzchen lzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix doc errors.

@ocelotl ocelotl requested a review from lzchen April 18, 2022 22:40
@lzchen
Copy link
Contributor

lzchen commented Apr 18, 2022

Might have to change [this](https://github.com/open-telemetry/opentelemetry-python/blob/main/docs/getting_started/metrics_example.py#L34 too?

@lzchen
Copy link
Contributor

lzchen commented Apr 18, 2022

Here too in contrib.

@ocelotl
Copy link
Contributor Author

ocelotl commented Apr 18, 2022

Here too in contrib.

Right, fixing.

@ocelotl ocelotl mentioned this pull request Apr 18, 2022
Closed
@ocelotl
Copy link
Contributor Author

ocelotl commented Apr 18, 2022

Here too in contrib.

Right, fixing.

Opened here

ocelotl and others added 5 commits April 19, 2022 18:05
@ocelotl
Rename Measurement to Observation
cc32a3a 
Fixes open-telemetry#2451
@ocelotl
Fix docs
e75f60e
@ocelotl @lzchen
Update CHANGELOG.md
95e3874 
Co-authored-by: Leighton Chen <lechen@microsoft.com>
@ocelotl @lzchen
Update CHANGELOG.md
94cd558 
Co-authored-by: Leighton Chen <lechen@microsoft.com>
@ocelotl
Fix examples
c7d8abb
@ocelotl ocelotl merged commit 3323ce2 into open-telemetry:main Apr 20, 2022
@ocelotl ocelotl deleted the issue_2451 branch April 20, 2022 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzchen lzchen lzchen approved these changes

@srikanthccv srikanthccv srikanthccv approved these changes

Assignees

@ocelotl ocelotl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider renaming observable callback return type from Measurement -> Observation
3 participants
@ocelotl @lzchen @srikanthccv