Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[opentelemetry-api] rename Default instruments to NoOp #2616

Merged
merged 5 commits into from
Apr 19, 2022

Conversation

codeboten
Copy link
Contributor

To remain consistent with NoOpMeterProvider and NoOpMeter, the instruments they produce have been renamed as well.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • This change requires a documentation update

Does This PR Require a Contrib Repo Change?

  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Documentation has been updated

To remain consistent with NoOpMeterProvider and NoOpMeter, the instruments they produce have been renamed as well.
@codeboten codeboten requested a review from a team April 18, 2022 19:43
@srikanthccv srikanthccv merged commit a41581f into open-telemetry:main Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants