Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Capture exception information in log attributes #2531

Merged
merged 16 commits into from
Mar 21, 2022
Merged

Capture exception information in log attributes #2531

merged 16 commits into from
Mar 21, 2022

Conversation

lzchen
Copy link
Contributor

@lzchen lzchen commented Mar 15, 2022

@lzchen lzchen requested a review from a team March 15, 2022 18:00
ocelotl
ocelotl requested changes Mar 17, 2022
View reviewed changes
Copy link
Contributor

@ocelotl ocelotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There may be a couple bugs hidden in the implementation.

aabmass
aabmass approved these changes Mar 18, 2022
View reviewed changes
Copy link
Member

@aabmass aabmass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

codeboten
codeboten approved these changes Mar 18, 2022
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, @ocelotl please review and see if your changes have been addressed 👍

@lzchen lzchen merged commit 97a36ea into open-telemetry:main Mar 21, 2022
@lzchen lzchen deleted the exc branch March 21, 2022 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srikanthccv srikanthccv srikanthccv left review comments

@codeboten codeboten codeboten approved these changes

@aabmass aabmass aabmass approved these changes

@ocelotl ocelotl ocelotl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Record exception information in logging
5 participants
@lzchen @codeboten @aabmass @ocelotl @srikanthccv