Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[logs] prevent None from causing problems #2410

Merged
merged 4 commits into from
Jan 26, 2022
Merged

[logs] prevent None from causing problems #2410

merged 4 commits into from
Jan 26, 2022

Commits on Jan 26, 2022

  1. [logs] prevent None from causing problems 

    If the trace or span ID is None for a log entry, the result would raise an error, this change prevents that.
    Alex Boten committed Jan 26, 2022
    Configuration menu
    Copy the full SHA
    453de6e View commit details
    Browse the repository at this point in the history

  2. update changelog

    Alex Boten committed Jan 26, 2022
    Configuration menu
    Copy the full SHA
    508fe68 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Diego Hurtado <ocelotl@users.noreply.github.com>
Co-authored-by: Srikanth Chekuri <srikanth.chekuri92@gmail.com>
    @ocelotl @srikanthccv
    3 people committed Jan 26, 2022
    Configuration menu
    Copy the full SHA
    63c4309 View commit details
    Browse the repository at this point in the history

  4. add unit test

    Alex Boten committed Jan 26, 2022
    Configuration menu
    Copy the full SHA
    a6c9d0c View commit details
    Browse the repository at this point in the history