Clean up ProbabilitySampler for 64 bit trace IDs #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c24t
requested review from
a-feld,
carlosalberto,
lzchen,
Oberon00,
reyang and
toumorokoshi
as code owners
This change because mypy isn't willing to believe the exponent is always positive. See python/typeshed#285.
c24t
changed the title
|
I reverted most of the changes in f2251ea now that we've decided to use the low bits for sampling decisions for compatibility with 64 bit trace IDs in w3c/trace-context#349. This is now mostly a cosmetic and testing change. |
c24t
added
the
needs reviewers
Codecov Report
@@ Coverage Diff @@
## master #238 +/- ##
=========================================
Coverage ? 85.32%
=========================================
Files ? 38
Lines ? 1956
Branches ? 231
=========================================
Hits ? 1669
Misses ? 221
Partials ? 66Continue to review full report at Codecov.
|
codeboten
suggested changes
Feb 10, 2020
Co-Authored-By: alrex <alrex.boten@gmail.com>
mauriciovasquezbernal
approved these changes
Feb 11, 2020
| @@ -147,7 +148,7 @@ def test_probability_sampler(self): | |||
| trace.SpanContext( | |||
| 0xDEADBEF0, 0xDEADBEF1, trace_options=TO_SAMPLED | |||
| ), | |||
| 0x8000000000000001, | |||
| 0x8000000000000000, | |||
There was a problem hiding this comment.
Would 0x0 make it more clear?
There was a problem hiding this comment.
Same reason as above, but not a strong preference in either case.
codeboten
approved these changes
Feb 12, 2020
toumorokoshi
pushed a commit
to toumorokoshi/opentelemetry-python
that referenced
this pull request
Feb 17, 2020
Co-authored-by: alrex <alrex.boten@gmail.com>
srikanthccv
pushed a commit
to srikanthccv/opentelemetry-python
that referenced
this pull request
Nov 1, 2020
* feat: add BatchSpanProcessor * fix: remove default value, already done Ctor * fix: append the MS unit * fix: move unrefTimer function in core * fix: use SetInterval instead of SetTimer * fix: rename TraceOptions -> TraceFlags * Update packages/opentelemetry-basic-tracer/src/export/BatchSpanProcessor.ts Co-Authored-By: Olivier Albertini <olivier.albertini@montreal.ca> * fix: remove _MS * fix: rename _lastSpanWrite -> _lastSpanFlush
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #225.
This PR changes
ProbabilitySamplerso that it checks the left bits of the trace ID (following open-telemetry/opentelemetry-specification#331) instead of the right bits (like OpenCensus).Whether this is the right behavior depends on open-telemetry/opentelemetry-specification#331, and does break from the other clients.