Upgrade GRPC/protobuf related dependency and regenerate otlp protobufs #2201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aabmass
changed the title
aabmass
force-pushed
the
upgrade-grpc-proto-deps
branch
from
e7705bf
to
8dc86d9
Compare
aabmass
force-pushed
the
upgrade-grpc-proto-deps
branch
from
8dc86d9
to
022ff57
Compare
aabmass
commented
Oct 14, 2021
+1 for that. Automatic updates causes a lot of breakage and pain. I'd rather stay on older versions than have CI break every month. |
owais
approved these changes
Oct 15, 2021
srikanthccv
approved these changes
Oct 15, 2021
owais
added
the
Approve Public API check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2195
~=instead of>=../scripts/proto_codegen.shopentelemetry/proto/logsso updated the ignore in pyproject.toml to be more generalI'm wondering if we should pin dev-dependencies.txt and introduce some automation to bump them automatically instead of giving ranges