Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect headers parsing via environment variables #2103

Merged
merged 10 commits into from
Sep 20, 2021
Merged

Fix incorrect headers parsing via environment variables #2103

merged 10 commits into from
Sep 20, 2021

Conversation

srikanthccv
Copy link
Member

Description

This introduces internal parse_headers method following the spec for reading headers via environment variables. Fixes #1949

@srikanthccv srikanthccv marked this pull request as ready for review September 6, 2021 19:10
@srikanthccv srikanthccv requested a review from a team September 6, 2021 19:10
codeboten
codeboten reviewed Sep 7, 2021
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the format that we're parsing is in the spec, i would be ok with this being a public method available in the api. It's not a huge amount of code and could be useful to others.

opentelemetry-api/src/opentelemetry/util/_env.py Outdated Show resolved Hide resolved
@ocelotl ocelotl self-requested a review September 16, 2021 16:28
@srikanthccv srikanthccv added the Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary label Sep 17, 2021
@lzchen lzchen merged commit 796e070 into open-telemetry:main Sep 20, 2021
@srikanthccv srikanthccv deleted the issue-1949 branch September 20, 2021 17:43
@AlonMorgen AlonMorgen mentioned this pull request Oct 28, 2021
Closed
This was referenced Jan 14, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten left review comments

@owais owais owais approved these changes

@ocelotl ocelotl ocelotl approved these changes

Assignees
No one assigned
Labels
Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use w3c format for reading headers via environment variables
5 participants
@srikanthccv @owais @codeboten @ocelotl @lzchen