Pass OTLP metadata as tuple instead of string #1507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeboten
requested review from
a team,
toumorokoshi and
aabmass
and removed request for
a team
lzchen
reviewed
Jan 4, 2021
| @@ -169,6 +169,10 @@ def __init__( | |||
| insecure = False | |||
|
|
|||
| self._headers = headers or Configuration().EXPORTER_OTLP_HEADERS | |||
| if isinstance(self._headers, str): | |||
There was a problem hiding this comment.
Any reason we are changing from : to = delimiters? No opinion, just curious. Also, once we have a place where all the env vars are documented, this specific format should probably be outlined.
There was a problem hiding this comment.
lzchen
approved these changes
Jan 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The header data was previously passed in as a string, this was incorrect according to the definition of metadata in gRPC.
Fixes #1506
Type of change
Please delete options that are not relevant.
Does This PR Require a Contrib Repo Change?
Checklist: