Metrics API RFC 0009 #140

lzchen · 2019-09-16T21:35:32Z

Continued from this PR which should be merged first.

Changes in this PR:

Record Batch API in meter, to allowing recording of multiple metrics.
Change TimeSeries to Handle

Comments for Meter More comments Add more comments Fix typos

…try-python into metrics-rfc

c24t · 2019-09-17T05:57:54Z

FYI this is OTEP 9 now, I updated the title.

c24t · 2019-09-17T06:50:13Z

FYI you can change the base branch to another feature branch to get a useful diff for PRs like this (in this case it would be lzchen:metrics-rfc) and switch back to master after the other branch is merged.

Oberon00 · 2019-09-17T09:48:08Z

Although the total diff in this PR is actually smaller than in the previous. How much sense does the previous one still make?

lzchen · 2019-09-17T16:02:01Z

@c24t
Github only allows me to actively change the base branch to ones that are in the origin repo after a PR has been made, so I would have to make a new PR. I can make a new PR diffing my forked branches but the approvals should be made on this PR.

toumorokoshi

Nice! Thanks for keeping stuff up to date with RFCs.

toumorokoshi · 2019-09-17T18:52:27Z

opentelemetry-api/src/opentelemetry/metrics/examples/pre_aggregated.py

    "sum numbers over time",
    "number",
-    LABEL_KEYS,
+    metrics.ValueType.FLOAT,


will this also support just passing the object in? like float?

I understand idiomatic python as using base object types where applicable, so I feel like that's a good strategy.

toumorokoshi · 2019-09-17T18:55:09Z

Since "Cumulative" -> "Counter" was approved, should we add that? I feel like all APIs are already exposing things as Counter.

lzchen · 2019-09-17T20:38:48Z

@toumorokoshi
I believe my PR already used Counter instead of Cumulative

c24t · 2019-09-17T22:23:05Z

I can make a new PR diffing my forked branches but the approvals should be made on this PR.

It'll be easier to review this once #136 is merged.

lzchen · 2019-09-18T23:45:41Z

@c24t
Continuing the conversation in this PR.

What about creating the global Meter lazily? That would still let users configure Meter at runtime as long as they do so before the first call. I think it's a worthwhile goal to have a working default Tracer and Meter out of the box, without any user-provided config.

When you say lazily, does that mean instantiating a Meter when the API is imported? Similarly for tracer:

_TRACER = None  # type: typing.Optional[Tracer]
_TRACER_FACTORY = None  # type: typing.Optional[ImplementationFactory]

would be

_TRACER = Tracer() # type: typing.Optional[Tracer]
_TRACER_FACTORY = None  # type: typing.Optional[ImplementationFactory]

Something like this?

…try-python into metrics

for start_time and end_time Make lint happy Addressing comments Addressing comments Allowing 0 as start and end time Fix lint issues Metrics API RFC 0003 cont'd (open-telemetry#136) * Create functions Comments for Meter More comments Add more comments Fix typos * fix lint * Fix lint * fix typing * Remove options, constructors, seperate labels * Consistent naming for float and int * Abstract time series * Use ABC * Fix typo * Fix docs * seperate measure classes * Add examples * fix lint * Update to RFC 0003 * Add spancontext, measurebatch * Fix docs * Fix comments * fix lint * fix lint * fix lint * skip examples * white space * fix spacing * fix imports * fix imports * LabelValues to str * Black formatting * fix isort * Remove aggregation * Fix names * Remove aggregation from docs * Fix lint * metric changes * Typing * Fix lint * Fix lint * Add space * Fix lint * fix comments * address comments * fix comments Adding a working propagator, adding to integrations and example (open-telemetry#137) Adding a full, end-to-end example of propagation at work in the example application, including a test. Adding the use of propagators into the integrations. Metrics API RFC 0009 (open-telemetry#140) * Create functions Comments for Meter More comments Add more comments Fix typos * fix lint * Fix lint * fix typing * Remove options, constructors, seperate labels * Consistent naming for float and int * Abstract time series * Use ABC * Fix typo * Fix docs * seperate measure classes * Add examples * fix lint * Update to RFC 0003 * Add spancontext, measurebatch * Fix docs * Fix comments * fix lint * fix lint * fix lint * skip examples * white space * fix spacing * fix imports * fix imports * LabelValues to str * Black formatting * fix isort * Remove aggregation * Fix names * Remove aggregation from docs * Fix lint * metric changes * Typing * Fix lint * Fix lint * Add space * Fix lint * fix comments * handle, recordbatch * docs * Update recordbatch * black * Fix typo * remove ValueType * fix lint Console exporter (open-telemetry#156) Make use_span more flexible (closes open-telemetry#147). (open-telemetry#154) Co-Authored-By: Reiley Yang <reyang@microsoft.com> Co-Authored-By: Chris Kleinknecht <libc@google.com> WSGI fixes (open-telemetry#148) Fix http.url. Don't delay calling wrapped app. Skeleton for azure monitor exporters (open-telemetry#151) Add link to docs to README (open-telemetry#170) Move example app to the examples folder (open-telemetry#172) WSGI: Fix port 80 always appended in http.host (open-telemetry#173) Build and host docs via github action (open-telemetry#167) Add missing license boilerplate to a few files (open-telemetry#176) sdk/trace/exporters: add batch span processor exporter (open-telemetry#153) The exporters specification states that two built-in span processors should be implemented, the simple processor span and the batch processor span. This commit implements the latter, it is mainly based on the opentelemetry/java one. The algorithm implements the following logic: - a condition variable is used to notify the worker thread in case the queue is half full, so that exporting can start before the queue gets full and spans are dropped. - export is called each schedule_delay_millis if there is a least one new span to export. - when the processor is shutdown all remaining spans are exported. Implementing W3C TraceContext (fixes open-telemetry#116) (open-telemetry#180) * Implementing TraceContext (fixes open-telemetry#116) This introduces a w3c TraceContext propagator, primarily inspired by opencensus. fix time conversion bug (open-telemetry#182) Introduce Context.suppress_instrumentation (open-telemetry#181) Metrics Implementation (open-telemetry#160) * Create functions Comments for Meter More comments Add more comments Fix typos * fix lint * Fix lint * fix typing * Remove options, constructors, seperate labels * Consistent naming for float and int * Abstract time series * Use ABC * Fix typo * Fix docs * seperate measure classes * Add examples * fix lint * Update to RFC 0003 * Add spancontext, measurebatch * Fix docs * Fix comments * fix lint * fix lint * fix lint * skip examples * white space * fix spacing * fix imports * fix imports * LabelValues to str * Black formatting * fix isort * Remove aggregation * Fix names * Remove aggregation from docs * Fix lint * metric changes * Typing * Fix lint * Fix lint * Add space * Fix lint * fix comments * handle, recordbatch * docs * Update recordbatch * black * Fix typo * remove ValueType * fix lint * sdk * metrics * example * counter * Tests * Address comments * ADd tests * Fix typing and examples * black * fix lint * remove override * Fix tests * mypy * fix lint * fix type * fix typing * fix tests * isort * isort * isort * isort * noop * lint * lint * fix tuple typing * fix type * black * address comments * fix type * fix lint * remove imports * default tests * fix lint * usse sequence * remove ellipses * remove ellipses * black * Fix typo * fix example * fix type * fix type * address comments Implement Azure Monitor Exporter (open-telemetry#175) Span add override parameters for start_time and end_time (open-telemetry#179) CONTRIBUTING.md: Fix clone URL (open-telemetry#177) Add B3 exporter to alpha release table (open-telemetry#164) Update README for alpha release (open-telemetry#189) Update Contributing.md doc (open-telemetry#194) Add **simple** client/server examples (open-telemetry#191) Remove unused dev-requirements.txt (open-telemetry#200) The requirements are contained in tox.ini now. Fx bug in BoundedList for Python 3.4 and add tests (open-telemetry#199) * fix bug in BoundedList for python 3.4 and add tests collections.deque.copy() was introduced in python 3.5, this commit changes that by the deque constructor and adds some tests to BoundedList and BoundedDict to avoid similar problems in the future. Also, improve docstrings of BoundedList and BoundedDict classes Move util.time_ns to API. (open-telemetry#205) Add Jaeger exporter (open-telemetry#174) This adds a Jeager exporter for OpenTelemetry. This exporter is based on https://github.com/census-instrumentation/opencensus-python/tree/master/contrib/opencensus-ext-jaeger. The exporter uses thrift and can be configured to send data to the agent and also to a remote collector. There is a long discussion going on about how to include generated files in the repo, so for now just put them here. Add code coverage Revert latest commit Fix some "errors" found by mypy. (open-telemetry#204) Fix some errors found by mypy (split from open-telemetry#201). Update README for new milestones (open-telemetry#218) Refactor current span handling for newly created spans. (open-telemetry#198) 1. Make Tracer.start_span() simply create and start the Span, without setting it as the current instance. 2. Add an extra Tracer.start_as_current_span() to create the Span and set it as the current instance automatically. Co-Authored-By: Chris Kleinknecht <libc@google.com> Add set_status to Span (open-telemetry#213) Initial commit Initial version

* feat: node-tracer initial implementation * fix: config order * fix: build pipeline

lzchen added 30 commits July 30, 2019 14:52

Create functions

6ca4274

Comments for Meter More comments Add more comments Fix typos

fix lint

b23cec1

Fix lint

981eece

fix typing

8ea9709

Remove options, constructors, seperate labels

00b4f11

Consistent naming for float and int

34c87ce

Abstract time series

df8ae34

Use ABC

a2561ac

Fix typo

1ece493

Fix docs

ce9268a

seperate measure classes

f5f9f01

Add examples

74a1815

fix lint

0a0b8ee

Update to RFC 0003

555bf50

Add spancontext, measurebatch

d6b1113

Merge branch 'master' of https://github.com/open-telemetry/openteleme…

c819109

…try-python into metrics-rfc

Fix docs

18cfc71

Merge branch 'master' of https://github.com/open-telemetry/openteleme…

f646555

…try-python into metrics-rfc

Fix comments

a44cb47

fix lint

94eaad9

fix lint

fc251b2

fix lint

262f312

skip examples

66c0a56

white space

e2c4a7e

fix spacing

2fb7646

fix imports

eb711cb

fix imports

baa3a32

Merge branch 'master' of https://github.com/open-telemetry/openteleme…

5c30a9c

…try-python into metrics-rfc

LabelValues to str

211b20c

Black formatting

bffe040

lzchen added 3 commits September 16, 2019 12:07

fix comments

e59f7c4

handle, recordbatch

9946028

docs

e1a3101

lzchen requested review from a-feld, c24t, carlosalberto, Oberon00, reyang and toumorokoshi as code owners September 16, 2019 21:35

lzchen added 2 commits September 16, 2019 14:53

Update recordbatch

47d5209

black

2553b89

c24t changed the title ~~Metrics API RFC 0007~~ Metrics API RFC 0009 Sep 17, 2019

toumorokoshi approved these changes Sep 17, 2019

View reviewed changes

lzchen added 2 commits September 18, 2019 17:26

Merge branch 'master' of https://github.com/open-telemetry/openteleme…

15c2894

…try-python into metrics

Fix typo

ebcc567

carlosalberto approved these changes Sep 19, 2019

View reviewed changes

remove ValueType

41ee12c

lzchen mentioned this pull request Sep 19, 2019

Add metrics API #48

Closed

fix lint

62862a2

lzchen merged commit ca10173 into open-telemetry:master Sep 19, 2019

srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this pull request Nov 1, 2020

feat: node-tracer initial implementation (open-telemetry#140)

a15ccb9

* feat: node-tracer initial implementation * fix: config order * fix: build pipeline

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Metrics API RFC 0009 #140

Metrics API RFC 0009 #140

lzchen commented Sep 16, 2019 •

edited

Loading

c24t commented Sep 17, 2019

c24t commented Sep 17, 2019

Oberon00 commented Sep 17, 2019

lzchen commented Sep 17, 2019

toumorokoshi left a comment

toumorokoshi Sep 17, 2019

toumorokoshi Sep 17, 2019

toumorokoshi commented Sep 17, 2019

lzchen commented Sep 17, 2019 •

edited

Loading

c24t commented Sep 17, 2019

lzchen commented Sep 18, 2019

Metrics API RFC 0009 #140

Metrics API RFC 0009 #140

Conversation

lzchen commented Sep 16, 2019 • edited Loading

c24t commented Sep 17, 2019

c24t commented Sep 17, 2019

Oberon00 commented Sep 17, 2019

lzchen commented Sep 17, 2019

toumorokoshi left a comment

Choose a reason for hiding this comment

toumorokoshi Sep 17, 2019

Choose a reason for hiding this comment

toumorokoshi Sep 17, 2019

Choose a reason for hiding this comment

toumorokoshi commented Sep 17, 2019

lzchen commented Sep 17, 2019 • edited Loading

c24t commented Sep 17, 2019

lzchen commented Sep 18, 2019

lzchen commented Sep 16, 2019 •

edited

Loading

lzchen commented Sep 17, 2019 •

edited

Loading