Workflow for PRs that would affect Contrib #1382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanielRN
requested review from
a team,
owais and
hectorhdzg
and removed request for
a team
3 tasks
aabmass
approved these changes
Nov 17, 2020
aabmass
reviewed
Nov 17, 2020
NathanielRN
force-pushed
the
core-pr-workflow
branch
from
c0e3ed9
to
559b525
Compare
NathanielRN
force-pushed
the
core-pr-workflow
branch
from
559b525
to
6b48413
Compare
|
@aabmass Re-requesting your review with steps that came as a result of our discussions 🙂 |
aabmass
approved these changes
Nov 17, 2020
|
@codeboten @lzchen can we merge this? |
NathanielRN
commented
Nov 18, 2020
Comment on lines
+114
to
+116
| 3. Modify the Core repo PR `CONTRIB_REPO_SHA` in `.github/workflows/test.yml` to | ||
| equal the commit SHA of the Contrib repo PR to pass Contrib repo tests (a sanity | ||
| check for the Maintainers & Approvers) |
There was a problem hiding this comment.
Optionally you can not do this, and just wait for the Contrib PR to get merged. The Contrib PR getting merged proves this Core PR is good because it uses this Core PR change!
Running it is just an optional sanity check for the Maintainers wanting to merge the Core PR.
Once Contrib PR is merged, since this points to master, you can just rerun tests and see it all work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As a follow up to this week's SIG meeting, we will add notes in
CONTRIBUTING.mdto explain the workflow for PRs which may affect Contrib repo packages.Type of change
Documentation update.
How Has This Been Tested?
N/A
Checklist: