Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

format_baggage does not escape non-ascii in baggage keys #2072

Closed
Arnatious opened this issue Aug 25, 2021 · 0 comments · Fixed by #2080
Closed

format_baggage does not escape non-ascii in baggage keys #2072

Arnatious opened this issue Aug 25, 2021 · 0 comments · Fixed by #2080

Comments

@Arnatious
Copy link
Contributor

opentelemetry-python/opentelemetry-api/src/opentelemetry/baggage/propagation/__init__.py

Line 100 in 4250078

key + "=" + urllib.parse.quote_plus(str(value))

The cpp implementation does this, and it looks like in python test strings there is url encoding.
https://github.com/open-telemetry/opentelemetry-cpp/blob/61d3c5e318830d10a0859befa046aa4847593764/api/include/opentelemetry/baggage/baggage.h#L174
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Aug 30, 2021
@ocelotl
Escape reserved characters in baggage keys
9eab6d5 
Fixes open-telemetry#2072
@ocelotl ocelotl mentioned this issue Aug 30, 2021
Merged
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Aug 31, 2021
@ocelotl
Escape reserved characters in baggage keys
304e2ee 
Fixes open-telemetry#2072
ocelotl added a commit that referenced this issue Aug 31, 2021
@ocelotl
Escape reserved characters in baggage keys (#2080)
a36a615 
* Escape reserved characters in baggage keys

Fixes #2072

* Add extract tests

* Fix lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Escape reserved characters in baggage keys ocelotl/opentelemetry-python
1 participant
@Arnatious