WIP

open-telemetry · Sep 9, 2021 · d0edbf7 · d0edbf7
1 parent bd59128
commit d0edbf7
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/opentelemetry-api/src/opentelemetry/baggage/__init__.py b/opentelemetry-api/src/opentelemetry/baggage/__init__.py
@@ -76,15 +76,15 @@ def set_baggage(
     Returns:
         A Context with the value updated
     """
+    baggage = dict(get_all(context=context))
     if _key_regex.fullmatch(str(name)) is None or (
         _value_regex.fullmatch(str(value)) is None
     ):
         _logger.warning(
             "name %s and value %s have been discarded", name, value
         )
-        return None
-    baggage = dict(get_all(context=context))
-    baggage[name] = value
+    else:
+        baggage[name] = value
     return set_value(_BAGGAGE_KEY, baggage, context=context)
 
 

diff --git a/opentelemetry-api/tests/baggage/test_baggage_propagation.py b/opentelemetry-api/tests/baggage/test_baggage_propagation.py
@@ -38,6 +38,8 @@ def _inject(self, values):
         """Test helper"""
         ctx = get_current()
         for k, v in values.items():
+            from ipdb import set_trace
+            set_trace()
             ctx = baggage.set_baggage(k, v, context=ctx)
         output = {}
         self.propagator.inject(output, context=ctx)