More review feedback

open-telemetry · May 5, 2020 · 14548cc · 14548cc
1 parent cc3cdb6
commit 14548cc
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/ext/opentelemetry-ext-aiohttp-client/src/opentelemetry/ext/aiohttp_client/__init__.py b/ext/opentelemetry-ext-aiohttp-client/src/opentelemetry/ext/aiohttp_client/__init__.py
@@ -116,7 +116,7 @@ def create_trace_config(
 
     Example usage:
 
-    .. code-block:: python
+    .. code:: python
 
         import aiohttp
         from opentelemetry.ext.aiohttp_client import create_trace_config
@@ -218,8 +218,7 @@ async def on_request_exception(
         _end_trace(trace_config_ctx)
 
     def _trace_config_ctx_factory(**kwargs):
-        if kwargs.get("trace_request_ctx", None) is None:
-            kwargs["trace_request_ctx"] = {}
+        kwargs.setdefault("trace_request_ctx", {})
         return types.SimpleNamespace(
             span_name=span_name, tracer=tracer, url_filter=url_filter, **kwargs
         )

diff --git a/ext/opentelemetry-ext-aiohttp-client/tests/test_aiohttp_client_integration.py b/ext/opentelemetry-ext-aiohttp-client/tests/test_aiohttp_client_integration.py
@@ -63,7 +63,6 @@ def test_url_path_span_name(self):
                 self.assertEqual(actual, expected)
                 self.assertIsInstance(actual, str)
 
-    # Helper to start an aiohttp test server and send an actual HTTP request to it.
     @staticmethod
     def _http_request(
         trace_config,
@@ -73,6 +72,7 @@ def _http_request(
         request_handler: typing.Callable = None,
         **kwargs
     ) -> typing.Tuple[str, int]:
+        """Helper to start an aiohttp test server and send an actual HTTP request to it."""
         async def do_request():
             async def default_handler(unused_request):
                 return aiohttp.web.Response(status=int(status_code))