opentelemetry-instrument: Fix documented options #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the change in `opentelemetry-instrument` to understand environment variables [0], the options documented in this README file are outdated. [0] open-telemetry/opentelemetry-python#1969
owais
approved these changes
Oct 15, 2021
lzchen
approved these changes
Oct 19, 2021
adamantike
deleted the
opentelemetry-instrument-fix-documented-options
branch
nicholasgribanov
pushed a commit
to nicholasgribanov/opentelemetry-python-contrib
that referenced
this pull request
Oct 29, 2021
nicholasgribanov
pushed a commit
to nicholasgribanov/opentelemetry-python-contrib
that referenced
this pull request
Oct 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since the change in
opentelemetry-instrumentto understand environment variables [0], the options documented in this README file are outdated.[0] open-telemetry/opentelemetry-python#1969
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
opentelemetry-instrument --helpDoes This PR Require a Core Repo Change?
Checklist: