Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codespell ci #1237

Merged
merged 10 commits into from
Aug 29, 2022
Merged

Codespell ci #1237

merged 10 commits into from
Aug 29, 2022

Conversation

galbash
Copy link
Contributor

@galbash galbash commented Aug 21, 2022

Description

Fixes #1236. Adding spellcheck on all files as part of the tox phase in the build. Additionally, fixed all discovered typos so the CI will pass.

Type of change

Please delete options that are not relevant.

  • Chore (codebase fix that does not change the behavior in any way)
  • This change requires a documentation update (internal)

How Has This Been Tested?

This PR essentially adds a test. To run spellcheck run tox -e spellcheck

Does This PR Require a Contrib Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated - no need
  • Unit tests have been added - no need
  • Documentation has been updated - the internal one, in CONTRIBUTING.md

@galbash
Copy link
Contributor Author

galbash commented Aug 21, 2022

broken down to two commits to enable easy review:

  1. adding codespell to the CI
  2. fixing typos

.codespellrc Outdated Show resolved Hide resolved
@galbash galbash marked this pull request as ready for review August 21, 2022 14:11
@galbash galbash requested a review from a team August 21, 2022 14:11
.codespellrc Outdated Show resolved Hide resolved
galbash and others added 3 commits August 24, 2022 12:32
Co-authored-by: Srikanth Chekuri <srikanth.chekuri92@gmail.com>
@galbash
Copy link
Contributor Author

galbash commented Aug 24, 2022

fixed linting

@srikanthccv srikanthccv merged commit 18e056b into open-telemetry:main Aug 29, 2022
@galbash galbash deleted the codespell-ci branch August 29, 2022 14:52
shalevr added a commit to shalevr/opentelemetry-python-contrib that referenced this pull request Aug 30, 2022
* main:
  Codespell ci (open-telemetry#1237)
  aiohttp-client: Fix producing additional spans with each newly created ClientSession (open-telemetry#1246)
  Remove support for 3.6 (open-telemetry#853)
  Added the Licence and Manifest file
  Restore metrics in django (open-telemetry#1208)
  fix typo in example codes (open-telemetry#1240)
  boto3sqs: Make propagation compatible with other instrumentations and add 'messaging.url' span attribute (open-telemetry#1234)
  Release 1.12.0-0.33b0 (open-telemetry#1223)
  Fix Flask instrumentation doc link (open-telemetry#1216)
  Feature/metrics instrumentation urllib3 (open-telemetry#1198)
  Metric instrumentation asgi (open-telemetry#1197)
  Metrics instrumentation flask (open-telemetry#1186)
  Adding sqlalchemy native tags in sqlalchemy commenter (open-telemetry#1206)
  ci: fix docs workflow failure (open-telemetry#1211)
  Add psycopg2 native tags to sqlcommenter (open-telemetry#1203)
  SQLCommenter semicolon bug fix (open-telemetry#1200)
  Sync with sdk setup from setUpClass to setUp (open-telemetry#1193)

# Conflicts:
#	CHANGELOG.md
#	instrumentation/opentelemetry-instrumentation-tornado/src/opentelemetry/instrumentation/tornado/__init__.py
#	instrumentation/opentelemetry-instrumentation-tornado/src/opentelemetry/instrumentation/tornado/client.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding spellcheck to the CI
5 participants