updated type hints for getters and setters #1106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @alanisaac : Can you please resolve the build errors? |
|
This is my first set of changes to these repos, so bear with me if I've gotten anything wrong here: This PR is dependent on open-telemetry/opentelemetry-python#2657 which was just merged today. IIUC, this repository uses the latest main branch from core, so I wouldn't have expected it to go through (I put this PR up a little preemptively). Hopefully this latest push should pass, but I'll keep an eye on the build status in case there's a different issue. |
|
@alanisaac bump the core repo sha here https://github.com/open-telemetry/opentelemetry-python-contrib/blob/main/.github/workflows/test.yml#L9 |
srikanthccv
approved these changes
May 29, 2022
jeremydvoss
pushed a commit
to jeremydvoss/opentelemetry-python-contrib
that referenced
this pull request
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes typing for Getter and Setter to be generic, in line with the parallel change in the core library. See open-telemetry/opentelemetry-python#2657
Fixes #1105
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.