Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix EOF and invalid character issue in metrics payload #499

Merged
merged 3 commits into from
Jul 12, 2023
Merged

Fix EOF and invalid character issue in metrics payload #499

merged 3 commits into from
Jul 12, 2023

Conversation

ZaradarBH
Copy link
Contributor

The metrics example uses "I'm" which causes havoc with curl on WSL2 resulting in a EOF error. Changing to "I`m" resolves this annoying issue :)

@ZaradarBH ZaradarBH requested a review from a team July 12, 2023 13:20
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 12, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@ZaradarBH
Update metrics.json
bc9e249 
Changing to "I am a...." based on maintainer request
@tigrannajaryan tigrannajaryan changed the title Fix EOF issue in metrics payload Fix EOF and invalid character issue in metrics payload Jul 12, 2023
@tigrannajaryan tigrannajaryan merged commit afcd2aa into open-telemetry:main Jul 12, 2023
13 checks passed
@MrAlias MrAlias mentioned this pull request Jan 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tigrannajaryan tigrannajaryan tigrannajaryan approved these changes

@reyang reyang reyang approved these changes

Assignees

@tigrannajaryan tigrannajaryan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZaradarBH @tigrannajaryan @reyang