Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the inclusivity of exponential histogram bounds #409

Merged
merged 2 commits into from
Aug 19, 2022

Conversation

jmacd
Copy link
Contributor

@jmacd jmacd commented Jun 28, 2022

The Prometheus project is strongly opposed to the use of lower-inclusive boundaries and has requested that OpenTelemetry change its position. This is the implied change, for demonstration.

This is not meant to be reviewed without the accompanying proposal, please follow open-telemetry/opentelemetry-specification#2611.

@jmacd jmacd changed the title Change the exponential histogram boundary condition DRAFT: Change the inclusivity of exponential histogram bounds Jun 28, 2022
@jmacd
Copy link
Contributor Author

jmacd commented Aug 15, 2022

The corresponding specification change merged: open-telemetry/opentelemetry-specification#2633

@jmacd jmacd marked this pull request as ready for review August 15, 2022 16:28
@jmacd jmacd requested review from a team August 15, 2022 16:28
@jmacd jmacd changed the title DRAFT: Change the inclusivity of exponential histogram bounds Change the inclusivity of exponential histogram bounds Aug 15, 2022
@jmacd jmacd merged commit 724e427 into open-telemetry:main Aug 19, 2022
@jmacd jmacd deleted the jmacd/histobounds branch August 19, 2022 14:46
VinozzZ pushed a commit to VinozzZ/opentelemetry-proto that referenced this pull request Jun 21, 2024
VinozzZ pushed a commit to VinozzZ/opentelemetry-proto that referenced this pull request Jun 21, 2024
VinozzZ pushed a commit to VinozzZ/opentelemetry-proto that referenced this pull request Jun 21, 2024
VinozzZ pushed a commit to VinozzZ/opentelemetry-proto that referenced this pull request Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants