Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change OTLP/HTTP port (#389) #398

Merged
merged 1 commit into from
Aug 14, 2021
Merged

Conversation

0xRenegade
Copy link
Contributor

No description provided.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 13, 2021

CLA Signed

The committers are authorized under a signed CLA.

@codecov
Copy link

codecov bot commented Aug 13, 2021

Codecov Report

Merging #398 (da51968) into main (f9948ef) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #398   +/-   ##
=========================================
  Coverage     93.96%   93.96%           
  Complexity      681      681           
=========================================
  Files            54       54           
  Lines          1624     1624           
=========================================
  Hits           1526     1526           
  Misses           98       98           
Impacted Files Coverage Δ
contrib/OtlpGrpc/Exporter.php 95.71% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9948ef...da51968. Read the comment docs.

@bobstrecansky bobstrecansky merged commit 8e64874 into open-telemetry:main Aug 14, 2021
@SeanHood
Copy link
Contributor

This PR changed the default port for OTLP/GRPC as well as OTLP/HTTP. I think only the latter was intended to be changed.

To add confusion to the mix, open-telemetry/opentelemetry-specification#1847 the new OTLP/HTTP port change in the spec had been reverted as it may be possible after all.

@bobstrecansky
Copy link
Collaborator

Yeah, just saw that - we can revert this PR for now if that's cool with you @SeanHood .

@SeanHood
Copy link
Contributor

I think that might be best for now

bobstrecansky added a commit that referenced this pull request Aug 16, 2021
@bobstrecansky
Copy link
Collaborator

If you'll do me a huge favor and open the revert for this PR, I'll approve and merge it.

SeanHood added a commit to SeanHood/opentelemetry-php that referenced this pull request Aug 17, 2021
bobstrecansky pushed a commit that referenced this pull request Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants