-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change OTLP/HTTP port (#389) #398
Conversation
|
Codecov Report
@@ Coverage Diff @@
## main #398 +/- ##
=========================================
Coverage 93.96% 93.96%
Complexity 681 681
=========================================
Files 54 54
Lines 1624 1624
=========================================
Hits 1526 1526
Misses 98 98
Continue to review full report at Codecov.
|
This PR changed the default port for OTLP/GRPC as well as OTLP/HTTP. I think only the latter was intended to be changed. To add confusion to the mix, open-telemetry/opentelemetry-specification#1847 the new OTLP/HTTP port change in the spec had been reverted as it may be possible after all. |
Yeah, just saw that - we can revert this PR for now if that's cool with you @SeanHood . |
I think that might be best for now |
If you'll do me a huge favor and open the revert for this PR, I'll approve and merge it. |
This reverts commit 8e64874.
No description provided.