Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update import-in-the-middle #4806

Merged
merged 3 commits into from
Jun 19, 2024

Conversation

timfish
Copy link
Contributor

@timfish timfish commented Jun 19, 2024

import-in-the-middle has had a few more bug fixes which have been released as v1.8.1 so I've bumper the version. This also included fixed types so no more type casting through unknown to get the types working!

The v1.8.0 release has also been added to Github so I updated the previous changelog entry to point to that.

@timfish timfish marked this pull request as ready for review June 19, 2024 01:05
@timfish timfish requested a review from a team June 19, 2024 01:05
Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks. I'll merge this in.

I think now we can now also consider changing the dependency to import-in-the-middle to a caret range as many of the issues we were dealing with in previous versions are now resolved.

@pichlermarc pichlermarc added this pull request to the merge queue Jun 19, 2024
Merged via the queue into open-telemetry:main with commit c07aa53 Jun 19, 2024
19 checks passed
@timfish timfish deleted the fix/import-in-the-middle branch June 19, 2024 09:19
@timfish
Copy link
Contributor Author

timfish commented Jun 19, 2024

we can now also consider changing the dependency to import-in-the-middle to a caret range

That would reduce the workload!

Does iitm have tests that cover the things otel rely on?

@pichlermarc
Copy link
Member

@timfish yes it does. The main reason we pinned it was nodejs/import-in-the-middle#57. @trentm added tests for it in nodejs/import-in-the-middle#66.

@timfish feel free to open the PR to use a caret range, then I'll merge it in :)

Zirak pushed a commit to Zirak/opentelemetry-js that referenced this pull request Sep 14, 2024
* fix: Update `import-in-the-middle`

* add changelog entry

* linting is important
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants