Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sdk-node): register context manager if no tracer options are provided #4781

Merged
merged 3 commits into from
Jun 11, 2024
Merged

fix(sdk-node): register context manager if no tracer options are provided #4781

merged 3 commits into from
Jun 11, 2024

Conversation

pichlermarc
Copy link
Member

Which problem is this PR solving?

Context managers were not properly registered when no trace-releated options were passed to the NodeSDK constructor.

Fixes #4776

Short description of the changes

Falls back to the raw contextManager option in case the tracer options are undefined.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Added Unit test

@pichlermarc pichlermarc requested a review from a team June 10, 2024 10:59
@pichlermarc pichlermarc mentioned this pull request Jun 10, 2024
Closed
@pichlermarc pichlermarc added this pull request to the merge queue Jun 11, 2024
Merged via the queue into open-telemetry:main with commit 05e2699 Jun 11, 2024
19 checks passed
@pichlermarc pichlermarc deleted the fix/4776-context-manager-not-registered branch June 11, 2024 07:26
@pichlermarc pichlermarc mentioned this pull request Jun 19, 2024
Merged
@simlarsen simlarsen mentioned this pull request Jul 12, 2024
Merged
This was referenced Jul 12, 2024
Open
Open
This was referenced Jul 12, 2024
Closed
Closed
Closed
This was referenced Jul 17, 2024
Open
Open
@DevMockSec DevMockSec mentioned this pull request Jul 17, 2024
Open
@Gal-Doron Gal-Doron mentioned this pull request Jul 17, 2024
Open
This was referenced Jul 18, 2024
Open
Open
This was referenced Jul 24, 2024
Open
Open
@simlarsen simlarsen mentioned this pull request Jul 26, 2024
Merged
@krischarbonneau krischarbonneau mentioned this pull request Jul 30, 2024
Merged
This was referenced Aug 9, 2024
Open
Open
This was referenced Aug 15, 2024
Closed
Closed
@WontonSam WontonSam mentioned this pull request Sep 10, 2024
Open
This was referenced Sep 12, 2024
Open
Open
Open
Open
Zirak pushed a commit to Zirak/opentelemetry-js that referenced this pull request Sep 14, 2024
@pichlermarc @Zirak
fix(sdk-node): register context manager if no tracer options are prov…
16cf4df 
…ided (open-telemetry#4781)

* fix(sdk-node): register context manager if no tracer options are provided

* chore: add changelog entry
@WontonSam WontonSam mentioned this pull request Sep 18, 2024
Open
@saidsef saidsef mentioned this pull request Sep 18, 2024
Merged
@micahg micahg mentioned this pull request Sep 18, 2024
Open
@danqueb danqueb mentioned this pull request Sep 19, 2024
Open
This was referenced Sep 19, 2024
Open
Open
@WontonSam WontonSam mentioned this pull request Sep 19, 2024
Open
@zx8086 zx8086 mentioned this pull request Sep 19, 2024
Open
@WontonSam WontonSam mentioned this pull request Sep 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-luna david-luna david-luna approved these changes

@maryliag maryliag maryliag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom context manager not respected when span processors / exporters are configured via env vars
3 participants
@pichlermarc @david-luna @maryliag