Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(instrumentation): remove peer-dependency on @opentelemetry/api-logs #4515

Merged

Conversation

pichlermarc
Copy link
Member

@pichlermarc pichlermarc commented Feb 29, 2024

we added @opentelemetry/api-logs as a peerDependency when it should've been a dependency, requiring everyone using the package to install an old @opentelemetry/api-logs package.

fixes #4516

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Merging #4515 (2540015) into main (7be35c7) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4515   +/-   ##
=======================================
  Coverage   92.40%   92.40%           
=======================================
  Files         330      330           
  Lines        9531     9531           
  Branches     2036     2036           
=======================================
  Hits         8807     8807           
  Misses        724      724           

@pichlermarc pichlermarc marked this pull request as ready for review February 29, 2024 09:47
@pichlermarc pichlermarc requested a review from a team February 29, 2024 09:47
@pichlermarc pichlermarc added bug Something isn't working priority:p1 Bugs which cause problems in end-user applications such as crashes, data inconsistencies, etc labels Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority:p1 Bugs which cause problems in end-user applications such as crashes, data inconsistencies, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@opentelemetry/instrumentation requires old @opentelemetry/api-logs peer dep
2 participants