Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: mark otlp exporters experimental #2490

Merged
merged 6 commits into from
Sep 27, 2021

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Sep 22, 2021

Per discussions in SIG mark the otlp exporters as unstable until the trace functionality is split from them.

@dyladan dyladan requested a review from a team September 22, 2021 21:01
@codecov
Copy link

codecov bot commented Sep 22, 2021

Codecov Report

Merging #2490 (d8b6c0e) into main (d41fa7b) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2490      +/-   ##
==========================================
- Coverage   93.27%   93.25%   -0.02%     
==========================================
  Files         125      137      +12     
  Lines        4445     5043     +598     
  Branches      931     1067     +136     
==========================================
+ Hits         4146     4703     +557     
- Misses        299      340      +41     
Impacted Files Coverage Δ
...ages/opentelemetry-exporter-otlp-http/src/types.ts 100.00% <0.00%> (ø)
...lemetry-exporter-otlp-http/src/transformMetrics.ts 95.71% <0.00%> (ø)
packages/opentelemetry-sdk-trace-web/src/types.ts 100.00% <0.00%> (ø)
...-sdk-trace-web/src/enums/PerformanceTimingNames.ts 100.00% <0.00%> (ø)
...entelemetry-sdk-trace-web/src/WebTracerProvider.ts 100.00% <0.00%> (ø)
...ry-context-zone-peer-dep/src/ZoneContextManager.ts 85.18% <0.00%> (ø)
...telemetry-sdk-trace-web/src/StackContextManager.ts 94.28% <0.00%> (ø)
...lemetry-exporter-otlp-http/src/OTLPExporterBase.ts 92.15% <0.00%> (ø)
.../opentelemetry-exporter-otlp-http/src/transform.ts 88.69% <0.00%> (ø)
...es/opentelemetry-context-zone-peer-dep/src/util.ts 100.00% <0.00%> (ø)
... and 3 more

Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, there is some failure in karma config thats why the browser tests are failing, maybe path is not updated etc. ?

Copy link
Member

@vmarchaud vmarchaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, PR need rebase though

@jsuereth
Copy link

QQ: Is OTel-js going to support OTLP export when the 1.0 is announced?

@dyladan
Copy link
Member Author

dyladan commented Sep 27, 2021

@jsuereth we don't want to release the exporter as 1.0 while it depends on the unfinished metric api/sdk. we are moving it to experimental while the trace functionality is split out of it so the 1.0 is unblocked. the exporter with trace-only will be released as 1.0 when it is ready.

@dyladan

This comment has been minimized.

@jsuereth
Copy link

@dyladan I guess I'm asking, as a user of OTel ecosystem, are we going to advertise users adopt 1.0 against the unstable receiver for OTEL or are we going to wait to advertise until the OTEL receiver is stable? Not trying to hold up this PR just wanted to understand the implications for when users ask about adopting Otel-JS

@dyladan
Copy link
Member Author

dyladan commented Sep 27, 2021

@dyladan I guess I'm asking, as a user of OTel ecosystem, are we going to advertise users adopt 1.0 against the unstable receiver for OTEL or are we going to wait to advertise until the OTEL receiver is stable? Not trying to hold up this PR just wanted to understand the implications for when users ask about adopting Otel-JS

I think it is fine to recommend users use the unstable otlp exporter as long as they understand that they will need to upgrade to the stable trace exporter in the near future.

@dyladan dyladan merged commit f0dc893 into open-telemetry:main Sep 27, 2021
@dyladan dyladan deleted the experimental-otlp-exporters branch September 27, 2021 20:30
@tedsuo
Copy link

tedsuo commented Sep 28, 2021

sounds good to me, given that the tracing portion of the exporter is "stable," and changing exporters doesn't create issues in the same way that breaking an API does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants