-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace 55681 endpoint with 4318 endpoint for HTTP collector #603
Replace 55681 endpoint with 4318 endpoint for HTTP collector #603
Conversation
b9ab870
to
4330faf
Compare
Codecov Report
@@ Coverage Diff @@
## main #603 +/- ##
==========================================
- Coverage 95.29% 94.71% -0.59%
==========================================
Files 10 16 +6
Lines 701 813 +112
Branches 142 162 +20
==========================================
+ Hits 668 770 +102
- Misses 33 43 +10
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should wait till core repo will change default port and then update the whole contrib - all packages and examples at once after core is released
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
PR in core repo: open-telemetry/opentelemetry-js#2557 |
@NathanielRN , now that the change is merged in core repo, can you please solve the conflicts and upgrade the collector image so we can merge this PR? |
2130d88
to
edde512
Compare
edde512
to
107ff7e
Compare
Which problem is this PR solving?
Follow up to core repo PR here: open-telemetry/opentelemetry-js#2395
The specifications just updated the HTTP port to be
4318
in this PR: open-telemetry/opentelemetry-specification#1839Likewise, the Collector also updated from
55681
to4318
open-telemetry/opentelemetry-collector#3743, but will support both for some time.Short description of the changes
4318