Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update otel-js to 1.21.0/0.48.0 #1914

Merged

Conversation

pichlermarc
Copy link
Member

@pichlermarc pichlermarc commented Jan 26, 2024

Which problem is this PR solving?

  • fix(deps): update otel core experimental to ^0.47.0 #1905 is failing due to the package-lock.json being only partially updated, causing 1.19.0 to be pulled in. This PR that by re-generating package-lock.json.
  • I also had to bump the version on @types/koa to 2.14.0 because it became incompatible with the newer one that's pulled in by another package.
  • I also had to pin nise (dev dependency) in one package, as a later version would've required a polyfill for process.
  • In chore(deps): update otel-core experimental to ^0.47.0 #1906 we discovered that we can't use import-in-the-middle >1.7.2 so we re-released core with the version again downgraded and pinned to 1.7.1, to avoid crashes of end-user apps - more info on the linked PR.

Supersedes #1906
Fixes #1911, #1892

Short description of the changes

  • Updated a lot of packages. Third time's the charm?

BEGIN_COMMIT_OVERRIDE
feat(deps): update otel-js to 1.21.0/0.48.0
END_COMMIT_OVERRIDE

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

Merging #1914 (e5dba1f) into main (12834d5) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1914   +/-   ##
=======================================
  Coverage   91.50%   91.50%           
=======================================
  Files         145      145           
  Lines        7431     7431           
  Branches     1489     1489           
=======================================
  Hits         6800     6800           
  Misses        631      631           

@pichlermarc
Copy link
Member Author

Codecov failing is unrelated.

@pichlermarc pichlermarc merged commit 9624486 into open-telemetry:main Jan 29, 2024
14 of 17 checks passed
@pichlermarc pichlermarc deleted the chore/update-otel-js branch January 29, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support @opentelemetry/instrumentation v0.47.0