fix(koa): fix instrumentation of ESM-imported koa #1736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-luna
approved these changes
Nov 3, 2023
|
Hi, thanks for your contribution and sorry for the late review. # #1735 introduced a simple way to test if everything is working as intended with ESM instrumentations. Would you mind adding this to this PR as well? |
|
Hi @pichlermarc, I failed to create a proper test case based on the #1735 PR. Is there anyone can help? |
|
I can help add a test case. |
… spans are created; add asserts for the expected spans
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1736 +/- ##
==========================================
- Coverage 91.49% 91.47% -0.03%
==========================================
Files 144 144
Lines 7388 7394 +6
Branches 1474 1478 +4
==========================================
+ Hits 6760 6764 +4
- Misses 628 630 +2
|
trentm
approved these changes
Dec 5, 2023
|
Thanks for the reviews. I turned on the TAV tests here and I see that they fail, so I may need to dig into that. It might be a separate issue, though. Update: It was a race in the newly added test. Fixed in commit 06fc6ba. |
The ESM test case runs use-koa.mjs and expects some spans. It relies on the ordering of those spans (based on start time). In some runs two spans were starting in the same millisecond and the sort order was ill-defined, which caused tests to fail.
Merged
|
Thanks @chentsulin! |
37 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes