Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make SdkTracer.tracerEnabled mutable #6687

Merged

Conversation

jackshirazi
Copy link
Contributor

This allows the tracer to become enabled and disabled dynamically (though only by reflection at this stage). Doing just this change allows downstream agent distros to play around with APIs that would best work while not yet changing anything public in the SDK
Without this change, testing downstream is still possible but much more effortful

@jackshirazi jackshirazi requested a review from a team September 5, 2024 16:17
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.02%. Comparing base (5ca6177) to head (1421bb6).
Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6687      +/-   ##
============================================
+ Coverage     90.00%   90.02%   +0.01%     
- Complexity     6332     6353      +21     
============================================
  Files           703      703              
  Lines         19092    19138      +46     
  Branches       1883     1887       +4     
============================================
+ Hits          17184    17229      +45     
- Misses         1332     1333       +1     
  Partials        576      576              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jackshirazi and others added 2 commits September 5, 2024 20:16
Co-authored-by: jack-berg <34418638+jack-berg@users.noreply.github.com>
@jack-berg jack-berg merged commit 61a4b46 into open-telemetry:main Sep 5, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants